From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JKjuV-0002RC-5V
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:37:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JKjuS-0002Pq-S8
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:37:37 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JKjuS-0002Pn-Ls
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:37:36 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JKjuS-0005B7-8J
	for qemu-devel@nongnu.org; Thu, 31 Jan 2008 19:37:36 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 1 Feb 2008 00:37:27 +0000
References: <1201818980-27534-1-git-send-email-aliguori@us.ibm.com>
	<200801312354.24382.paul@codesourcery.com>
	<47A26714.4000204@us.ibm.com>
In-Reply-To: <47A26714.4000204@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802010037.30731.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH 1/6] Use correct types to enable > 2G
	support
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, Izik Eidus <izike@qumranet.com>, qemu-devel@nongnu.org

> >> +#define PHYS_RAM_MAX_SIZE (2047 * 1024 * 1024 * 1024ULL)
> >
> > This seems fairly arbitrary. Why? Any limit is certainly target specific.
>
> On a 32-bit host, a 2GB limit is pretty reasonable since you're limited
> in virtual address space.  On a 64-bit host, there isn't this
> fundamental limit.  If a target may have it's own limit but there is
> definitely a host imposed limit.
>
> 2047GBs is a somewhat arbitrary limit though for 64-bit hosts.  If you
> have a more logical suggestion, I'll happily change it.

Don't have a limit at all.

The reason we have the current 31-bit limit is because qemu is/was known to 
use a signed int do hold the size. With your code 64-bit hosts should be able 
to handle anything atoi can parse.

As mentioned on IRC, I also noticed that ram_save hasn't been updated.

Paul