From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] TCG
Date: Sat, 2 Feb 2008 03:34:08 +0000 [thread overview]
Message-ID: <200802020334.10618.paul@codesourcery.com> (raw)
In-Reply-To: <47A31AE8.1010402@bellard.org>
> I made minimal modifications in each target so that they can still work
> by using TCG and legacy "dyngen" micro operations. More work will be
> needed to convert each target to TCG, but it can be done progressively.
> Only the x86 and x86_64 targets have been significantly modified to use
> TCG.
When playing with this a bit with the ARM target I found it very easy to get
variables, immediate values and register indexes mixed up. e.g. using
gen_add_i32 instead of gen_add_i32, or gen_mov_i32(foo, rn) instead of
gen_ld_i32(foo, cpu_env, offsetof(CPUState, regs[rn]).
Would you object to a patch that changed then gen_* functions in tgc_op to use
an opaque type for variables? For performance reasons we probably want to
keep it as an in in production builds, but for debugging it's nice to be able
to catch the types of error mentioned above. IMHO it also helps to improve
the clarity of the code.
The changes should be mostly mechanical.
Paul
prev parent reply other threads:[~2008-02-02 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 13:13 [Qemu-devel] TCG Fabrice Bellard
2008-02-01 16:07 ` C.W. Betts
2008-02-01 17:04 ` Johannes Schindelin
2008-03-14 13:51 ` [Qemu-devel] TCG Alejandro Mery
2008-02-02 3:34 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802020334.10618.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).