From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JM1jp-0005AD-9S
	for qemu-devel@nongnu.org; Mon, 04 Feb 2008 08:51:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JM1jm-00057M-Jj
	for qemu-devel@nongnu.org; Mon, 04 Feb 2008 08:51:55 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JM1jm-00057H-Ew
	for qemu-devel@nongnu.org; Mon, 04 Feb 2008 08:51:54 -0500
Received: from atlas.linux2go.dk ([88.198.22.52])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sh@warma.dk>) id 1JM1jm-0005Ls-4K
	for qemu-devel@nongnu.org; Mon, 04 Feb 2008 08:51:54 -0500
Date: Mon, 4 Feb 2008 14:51:49 +0100
From: Soren Hansen <soren@ubuntu.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual
	Machine interface (v2)
Message-ID: <20080204135149.GD4554@butch.linux2go.dk>
References: <1201903921-1125-1-git-send-email-aliguori@us.ibm.com>
	<1201903921-1125-7-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="9UV9rz0O2dU/yYYn"
Content-Disposition: inline
In-Reply-To: <1201903921-1125-7-git-send-email-aliguori@us.ibm.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kvm-devel@lists.sourceforge.net


--9UV9rz0O2dU/yYYn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 01, 2008 at 04:12:01PM -0600, Anthony Liguori wrote:
> Index: qemu/hw/vga_int.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- qemu.orig/hw/vga_int.h	2008-02-01 15:23:45.000000000 -0600
> +++ qemu/hw/vga_int.h	2008-02-01 15:29:04.000000000 -0600
> @@ -145,11 +145,20 @@
>      void (*cursor_draw_line)(struct VGAState *s, uint8_t *d, int y);    \
>      /* tell for each page if it has been updated since the last time */ \
>      uint32_t last_palette[256];                                         \
> -    uint32_t last_ch_attr[CH_ATTR_SIZE]; /* XXX: make it dynamic */
> +    uint32_t last_ch_attr[CH_ATTR_SIZE]; /* XXX: make it dynamic */	\
> +    unsigned long map_addr;						\
> +    unsigned long map_end;
> =20
> =20
>  typedef struct VGAState {
>      VGA_STATE_COMMON
> +
> +    int32_t  aliases_enabled;
> +    int32_t  pad1;
> +    uint32_t aliased_bank_base[2];
> +    uint32_t aliased_bank_limit[2];
> +
> +

These need to move into VGA_STATE_COMMON instead. Otherwise vmware_vga
will get confoozled becuase it relies on vga.c for its vesa
implementation. The patch is at:

	http://people.ubuntu.com/~soren/0001-Move-common-VGAState-attributes-to-VG=
A_STATE_COMMON.patch

/me grumbles about sourceforge's mailing list archive thing completely
messing up the formatting of patches...

--=20
Soren Hansen
Virtualisation specialist
Ubuntu Server Team
http://www.ubuntu.com/

--9UV9rz0O2dU/yYYn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHpxh1onjfXui9pOMRAghXAJ9LPTCk/kclaFb+0kDFeYBuTdgKTwCeKQsh
p8tF1REhqX1FNDYBmYspT+Y=
=hGU4
-----END PGP SIGNATURE-----

--9UV9rz0O2dU/yYYn--