From: Paul Brook <paul@codesourcery.com>
To: Avi Kivity <avi@qumranet.com>
Cc: Izik Eidus <izike@qumranet.com>,
kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2)
Date: Sun, 10 Feb 2008 14:59:32 +0000 [thread overview]
Message-ID: <200802101459.33683.paul@codesourcery.com> (raw)
In-Reply-To: <47AF104C.3060401@qumranet.com>
On Sunday 10 February 2008, Avi Kivity wrote:
> Paul Brook wrote:
> >>> as far as i remember it was used to address something with
> >>> cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE
> >>> or ~TARGET_PAGE_SIZE,
> >>>
> >>> the fact is that i dont know if it ever fixed anything
> >>
> >> It fixes TARGET_PAGE_MASK, defined one line downscreen.
> >
> > That doesn't really answer the question. What was wrong with the original
> > definition?
>
> There are many instances of ((physical address) & TARGET_PAGE_MASK)
> scattered throughout the code. With 64-bit physical addresses, this
> causes truncation.
No it doesn't. TARGET_PAGE_MASK will be sign extended to the width of
physical_address. This is why I asked for a concrete example of something
that broke.
Paul
next prev parent reply other threads:[~2008-02-10 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 22:11 [Qemu-devel] [PATCH 0/6] Support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] [PATCH 1/6] Fix VMware VGA init call Anthony Liguori
2008-02-01 22:23 ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] [PATCH 2/6] Use correct types to enable > 2G support (v2) Anthony Liguori
2008-02-04 1:56 ` [Qemu-devel] " Anthony Liguori
2008-02-04 8:45 ` Izik Eidus
2008-02-04 15:31 ` Anthony Liguori
2008-02-10 10:48 ` Avi Kivity
2008-02-10 14:12 ` Paul Brook
2008-02-10 14:55 ` Avi Kivity
2008-02-10 14:59 ` Paul Brook [this message]
2008-02-10 15:14 ` Avi Kivity
2008-02-01 22:11 ` [Qemu-devel] [PATCH 3/6] SCI fixes (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] [PATCH 4/6] Fix daemonize options (v2) Anthony Liguori
2008-02-01 22:12 ` [Qemu-devel] [PATCH 5/6] Tell BIOS about the number of CPUs (v2) Anthony Liguori
2008-02-01 22:12 ` [Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-04 13:51 ` Soren Hansen
2008-02-04 15:14 ` [kvm-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802101459.33683.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=avi@qumranet.com \
--cc=izike@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).