From: Daniel Jacobowitz <drow@false.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH][Qemu-devel] Single stepping for PPC broken!
Date: Wed, 13 Feb 2008 08:44:06 -0500 [thread overview]
Message-ID: <20080213134406.GA19391@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0802130939190.6152@localhost>
On Wed, Feb 13, 2008 at 09:46:44AM +0100, Marius Groeger wrote:
> if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK) &&
> !ctx->singlestep_enabled) {
> ..
> } else {
> gen_set_T1(dest);
> #if defined(TARGET_PPC64)
> if (ctx->sf_mode)
> gen_op_b_T1_64();
> else
> #endif
> gen_op_b_T1();
> if (ctx->singlestep_enabled)
> gen_op_debug()
> }
>
> It seems to me that the second if (ctx->singlestep_enabled) is
> rendundant.
No, if you've gone to a different page without single step then you
don't need the debug trap.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-02-13 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 7:59 [Qemu-devel] Single stepping for PPC broken? Marius Groeger
2008-01-09 12:19 ` [Qemu-devel] Single stepping for PPC broken! Marius Groeger
2008-01-10 13:57 ` [PATCH][Qemu-devel] " Marius Groeger
2008-02-11 23:22 ` Rob Landley
2008-02-13 8:46 ` Marius Groeger
2008-02-13 13:44 ` Daniel Jacobowitz [this message]
2008-02-13 15:52 ` Marius Groeger
2008-02-13 16:19 ` Daniel Jacobowitz
2008-02-14 7:36 ` Marius Groeger
2008-03-11 23:16 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213134406.GA19391@caradoc.them.org \
--to=drow@false.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).