From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JPHuF-0002ak-0j
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 08:44:11 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JPHuD-0002YO-3F
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 08:44:10 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JPHuC-0002Y1-Mn
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 08:44:08 -0500
Received: from nan.false.org ([208.75.86.248])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <drow@false.org>) id 1JPHuC-0002Xq-97
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 08:44:08 -0500
Received: from nan.false.org (localhost [127.0.0.1])
	by nan.false.org (Postfix) with ESMTP id 5EA719811F
	for <qemu-devel@nongnu.org>; Wed, 13 Feb 2008 13:44:07 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55])
	by nan.false.org (Postfix) with ESMTP id 4014E98118
	for <qemu-devel@nongnu.org>; Wed, 13 Feb 2008 13:44:07 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69)
	(envelope-from <drow@caradoc.them.org>) id 1JPHuA-00054N-Ex
	for qemu-devel@nongnu.org; Wed, 13 Feb 2008 08:44:06 -0500
Date: Wed, 13 Feb 2008 08:44:06 -0500
From: Daniel Jacobowitz <drow@false.org>
Subject: Re: [PATCH][Qemu-devel] Single stepping for PPC broken!
Message-ID: <20080213134406.GA19391@caradoc.them.org>
References: <Pine.LNX.4.64.0801090849090.6836@localhost>
	<Pine.LNX.4.64.0801091312170.24129@localhost>
	<Pine.LNX.4.64.0801101454460.20346@localhost>
	<200802111722.50517.rob@landley.net>
	<Pine.LNX.4.64.0802130939190.6152@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0802130939190.6152@localhost>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Feb 13, 2008 at 09:46:44AM +0100, Marius Groeger wrote:
>   if ((tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK) &&
>      !ctx->singlestep_enabled) {
>   ..
>   } else {
>     gen_set_T1(dest);
> #if defined(TARGET_PPC64)
>     if (ctx->sf_mode)
>       gen_op_b_T1_64();
>      else
> #endif
>       gen_op_b_T1();
>     if (ctx->singlestep_enabled)
>       gen_op_debug()
>   }
> 
> It seems to me that the second if (ctx->singlestep_enabled) is 
> rendundant.

No, if you've gone to a different page without single step then you
don't need the debug trap.

-- 
Daniel Jacobowitz
CodeSourcery