qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] bdrv_flush error handling
Date: Wed, 20 Feb 2008 16:19:00 +0000	[thread overview]
Message-ID: <200802201619.01354.paul@codesourcery.com> (raw)
In-Reply-To: <20080220160457.GD14209@redhat.com>

> > Finally, it would perhaps be best if the block device emulators wrote
> > to the qemu console to complain if they give write errors.  Otherwise
> > the errno value and other important information will be lost, which
> > makes debugging hard.
>
> If by 'qemu console' you mean stderr, then fine, but please don't
> spew log messages to the  monitor console, because that'll make it
> very hard to interact with reliably from management tools.

Actually I think a better default would be for qemu to die right there and 
then.  If the host is getting IO errors then something is badly wrong, and 
you're probably screwed anyway.

Paul

  parent reply	other threads:[~2008-02-20 16:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 15:53 [Qemu-devel] [PATCH] bdrv_flush error handling Ian Jackson
2008-02-20 16:04 ` Daniel P. Berrange
2008-02-20 16:13   ` Ian Jackson
2008-02-20 16:19   ` Paul Brook [this message]
2008-02-20 16:23     ` Avi Kivity
2008-02-20 16:37       ` Ian Jackson
2008-02-20 16:46         ` Paul Brook
2008-02-20 16:53           ` Ian Jackson
2008-02-20 16:31             ` Jamie Lokier
2008-02-20 18:17               ` Paul Brook
2008-02-20 16:38                 ` Jamie Lokier
2008-02-20 18:22               ` Daniel P. Berrange
2008-02-20 19:01                 ` Anthony Liguori
2008-02-20 19:55                   ` Rick Vernam
2008-02-21  7:10                     ` Thomas Irlet
2008-02-21 17:19   ` Ben Taylor
2008-02-21 17:24     ` Daniel P. Berrange
2008-02-21 17:28       ` risc
2008-02-21 18:24         ` Daniel P. Berrange
2008-03-28 17:19 ` [Qemu-devel] " Ian Jackson
2008-04-26 15:15   ` andrzej zaborowski
2008-04-29 16:27     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802201619.01354.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).