From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JRrf2-0005bX-78 for qemu-devel@nongnu.org; Wed, 20 Feb 2008 11:19:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JRrf1-0005bL-DS for qemu-devel@nongnu.org; Wed, 20 Feb 2008 11:19:07 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JRrf1-0005bI-8Z for qemu-devel@nongnu.org; Wed, 20 Feb 2008 11:19:07 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JRrf0-0004Ej-T0 for qemu-devel@nongnu.org; Wed, 20 Feb 2008 11:19:07 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] bdrv_flush error handling Date: Wed, 20 Feb 2008 16:19:00 +0000 References: <18364.19722.241175.337829@mariner.uk.xensource.com> <20080220160457.GD14209@redhat.com> In-Reply-To: <20080220160457.GD14209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802201619.01354.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, "Daniel P. Berrange" > > Finally, it would perhaps be best if the block device emulators wrote > > to the qemu console to complain if they give write errors. Otherwise > > the errno value and other important information will be lost, which > > makes debugging hard. > > If by 'qemu console' you mean stderr, then fine, but please don't > spew log messages to the monitor console, because that'll make it > very hard to interact with reliably from management tools. Actually I think a better default would be for qemu to die right there and then. If the host is getting IO errors then something is badly wrong, and you're probably screwed anyway. Paul