[Qemu-devel] Re: [PATCH] linux-user/mmap v3: Testsuite + bugfixes

["Edgar E. Iglesias" <edgar.iglesias@axis.com>]

On Sat, Feb 23, 2008 at 10:58:12AM +0200, Felipe Contreras wrote:
> On Fri, Feb 22, 2008 at 5:32 PM, Edgar E. Iglesias
> <edgar.iglesias@axis.com> wrote:
> > Hi,
> >
> >  This is the third version of the linux-user/mmap bugfix patches:
> >
> >  * Let the native mmap choose addresses for unfixed mappings.
> >  * For file mappings, correct mapping of pages beyond EOF.
> >  * Adds a small testsuite for linux-user/mmap.
> >
> >  Tested with test-mmap for CRIS, MIPS, ARM and i386, simulated on linux-i686
> >   hosts.
> >
> >  Felipe, I think the problems you are seeing are related to large mmaps failing. By letting the native mmap choose the addresses for unfixed mmaps, I hope your segfaults will go away.
> 
> This patch does fix the weird issues I was having.
> 
> Does the test checks for the issues I had?

Hello Felipe,

Sorry for the delays. No, the checks won't find regressions with this particular issue. I'll try to write something when I get a chance.

Thanks for all the help debugging this.

Best regards
-- 
Edgar E. Iglesias
Axis Communications AB