From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JV0iO-0008MH-Mn for qemu-devel@nongnu.org; Fri, 29 Feb 2008 03:35:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JV0iM-0008Kj-D5 for qemu-devel@nongnu.org; Fri, 29 Feb 2008 03:35:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV0iM-0008Kb-4i for qemu-devel@nongnu.org; Fri, 29 Feb 2008 03:35:34 -0500 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JV0iL-000576-I5 for qemu-devel@nongnu.org; Fri, 29 Feb 2008 03:35:33 -0500 Received: from miranda.se.axis.com ([193.13.178.8]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JV0iK-0000Qi-Qj for qemu-devel@nongnu.org; Fri, 29 Feb 2008 03:35:33 -0500 Received: from axis.com (edgar.se.axis.com [10.93.151.1]) by miranda.se.axis.com (8.13.4/8.13.4/Debian-3sarge3) with ESMTP id m1T8ZKtd012463 for ; Fri, 29 Feb 2008 09:35:20 +0100 Date: Fri, 29 Feb 2008 11:34:50 +0100 From: "Edgar E. Iglesias" Message-ID: <20080229103450.GA13884@edgar.se.axis.com> References: <20080222153235.GB16991@edgar.se.axis.com> <94a0d4530802230058o773bf28eq21f021c7b7c50d0a@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94a0d4530802230058o773bf28eq21f021c7b7c50d0a@mail.gmail.com> Subject: [Qemu-devel] Re: [PATCH] linux-user/mmap v3: Testsuite + bugfixes Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Felipe Contreras Cc: qemu-devel@nongnu.org On Sat, Feb 23, 2008 at 10:58:12AM +0200, Felipe Contreras wrote: > On Fri, Feb 22, 2008 at 5:32 PM, Edgar E. Iglesias > wrote: > > Hi, > > > > This is the third version of the linux-user/mmap bugfix patches: > > > > * Let the native mmap choose addresses for unfixed mappings. > > * For file mappings, correct mapping of pages beyond EOF. > > * Adds a small testsuite for linux-user/mmap. > > > > Tested with test-mmap for CRIS, MIPS, ARM and i386, simulated on linux-i686 > > hosts. > > > > Felipe, I think the problems you are seeing are related to large mmaps failing. By letting the native mmap choose the addresses for unfixed mmaps, I hope your segfaults will go away. > > This patch does fix the weird issues I was having. > > Does the test checks for the issues I had? Hello Felipe, Sorry for the delays. No, the checks won't find regressions with this particular issue. I'll try to write something when I get a chance. Thanks for all the help debugging this. Best regards -- Edgar E. Iglesias Axis Communications AB