From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JV7OI-0003dj-1y
	for qemu-devel@nongnu.org; Fri, 29 Feb 2008 10:43:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JV7OG-0003Zn-5c
	for qemu-devel@nongnu.org; Fri, 29 Feb 2008 10:43:17 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JV7OF-0003Zd-VY
	for qemu-devel@nongnu.org; Fri, 29 Feb 2008 10:43:16 -0500
Received: from os.inf.tu-dresden.de ([141.76.48.99])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kauer@os.inf.tu-dresden.de>) id 1JV7OF-0002v3-GO
	for qemu-devel@nongnu.org; Fri, 29 Feb 2008 10:43:15 -0500
Received: from erwin.inf.tu-dresden.de ([141.76.48.80]
	helo=chrom.inf.tu-dresden.de)
	by os.inf.tu-dresden.de with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69)
	id 1JV7OE-0001vq-2d
	for qemu-devel@nongnu.org; Fri, 29 Feb 2008 16:43:14 +0100
Received: from kauer by chrom.inf.tu-dresden.de with local (Exim 4.69)
	(envelope-from <kauer@chrom.inf.tu-dresden.de>) id 1JV7OE-0008AE-KZ
	for qemu-devel@nongnu.org; Fri, 29 Feb 2008 16:43:14 +0100
Date: Fri, 29 Feb 2008 16:43:14 +0100
From: Bernhard Kauer <kauer@os.inf.tu-dresden.de>
Subject: Re: [Qemu-devel] [PATCH] allow update of MSR_EFER_SVM
Message-ID: <20080229154314.GA31173@chrom.inf.tu-dresden.de>
References: <20080227160716.GA9305@chrom.inf.tu-dresden.de>
	<50E1BA25-AC2A-48A2-AFF2-83630AE4BF9E@csgraf.de>
	<20080229094113.GB9305@chrom.inf.tu-dresden.de>
	<F91079F9-C033-4112-B905-56FD6CA85882@csgraf.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F91079F9-C033-4112-B905-56FD6CA85882@csgraf.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Feb 29, 2008 at 11:20:24AM +0100, Alexander Graf wrote:
> Keep in mind that updating the bit should fail within a virtual machine.

I found the following sentence in the manual:

	The effect of turning off EFER.SVME while a guest is running is undefined;
	therefore, the VMM should always prevent guests from writing EFER.

Therefore i think the wrmsr-code is just fine, as it is in my patch.


	Bernhard Kauer