From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JZtRs-0006iY-PD for qemu-devel@nongnu.org; Thu, 13 Mar 2008 15:50:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JZtRr-0006iL-Fu for qemu-devel@nongnu.org; Thu, 13 Mar 2008 15:50:43 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JZtRr-0006iI-9N for qemu-devel@nongnu.org; Thu, 13 Mar 2008 15:50:43 -0400 Received: from hall.aurel32.net ([88.191.38.19]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JZtRq-0007bk-N7 for qemu-devel@nongnu.org; Thu, 13 Mar 2008 15:50:43 -0400 Received: from volta-wlan.aurel32.net ([2002:52e8:2fb:ffff:21d:e0ff:fe49:1047] helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JZtRm-00028E-M7 for qemu-devel@nongnu.org; Thu, 13 Mar 2008 20:50:38 +0100 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1JZtRz-0004lD-3k for qemu-devel@nongnu.org; Thu, 13 Mar 2008 20:50:51 +0100 Date: Thu, 13 Mar 2008 20:50:51 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] fix SDL mouse events processing Message-ID: <20080313195051.GA17899@volta.aurel32.net> References: <20080305114704.GC9747@implementation.uk.xensource.com> <20080305121802.GD9747@implementation.uk.xensource.com> <20080305135453.GE9786@implementation.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20080305135453.GE9786@implementation.uk.xensource.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Mar 05, 2008 at 01:54:53PM +0000, Samuel Thibault wrote: > Here is a revamped patch: > > This fixes SDL mouse events processing: > - GetRelativeMouseState() always returns the last position, so when the > polling loop gets several mouse events in one go, we would send > useless 'no move' events, let's avoid that. > - So as to make sure we don't miss any mouse click / double click, we > should not use GetRelativeMouseState() to get the button state, but > rather keep records of the button state ourselves (I've requested SDL > developers to provide it directly in the event in SDL 1.3). > - bev->state doesn't contain the button state but whether the event is a press > or a release. Use bev->button instead. This patch does not apply anymore. Could you please to redo it against the current CVS? -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net