Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

[Samuel Thibault <samuel.thibault@eu.citrix.com>]

Aurelien Jarno, le Thu 13 Mar 2008 20:50:51 +0100, a écrit :
> On Wed, Mar 05, 2008 at 01:54:53PM +0000, Samuel Thibault wrote:
> > This fixes SDL mouse events processing:
> > - GetRelativeMouseState() always returns the last position, so when the
> >   polling loop gets several mouse events in one go, we would send
> >   useless 'no move' events, let's avoid that.
> > - So as to make sure we don't miss any mouse click / double click, we
> >   should not use GetRelativeMouseState() to get the button state, but
> >   rather keep records of the button state ourselves (I've requested SDL
> >   developers to provide it directly in the event in SDL 1.3).
> > - bev->state doesn't contain the button state but whether the event is a press
> >   or a release. Use bev->button instead.
> 
> This patch does not apply anymore. Could you please to redo it against
> the current CVS?

Mmm, well, it actually is conflicting with the "mouse smoothness" patch:
the question is: after the 30ms period, if we got several mouse motion
events, should we merge them into a single one for the guest, or should
we provide all of them (hence making the cursor looking more smooth, but
requiring more treatments from the guest)?

Samuel