From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JZwzb-0001lX-UX for qemu-devel@nongnu.org; Thu, 13 Mar 2008 19:37:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JZwza-0001ku-IS for qemu-devel@nongnu.org; Thu, 13 Mar 2008 19:37:47 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JZwza-0001kr-B7 for qemu-devel@nongnu.org; Thu, 13 Mar 2008 19:37:46 -0400 Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JZwzZ-0000AA-OZ for qemu-devel@nongnu.org; Thu, 13 Mar 2008 19:37:46 -0400 Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout03-winn.ispmail.ntl.com with ESMTP id <20080313234048.OYIQ19530.mtaout03-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com> for ; Thu, 13 Mar 2008 23:40:48 +0000 Received: from implementation.famille.thibault.fr ([82.21.96.230]) by aamtaout04-winn.ispmail.ntl.com with ESMTP id <20080313233744.QGRD29112.aamtaout04-winn.ispmail.ntl.com@implementation.famille.thibault.fr> for ; Thu, 13 Mar 2008 23:37:44 +0000 Received: from samy by implementation.famille.thibault.fr with local (Exim 4.69) (envelope-from ) id 1JZwzS-0001Gx-I4 for qemu-devel@nongnu.org; Fri, 14 Mar 2008 00:37:38 +0100 Date: Thu, 13 Mar 2008 23:37:33 +0000 From: Samuel Thibault Subject: Re: [Qemu-devel] [PATCH] fix SDL mouse events processing Message-ID: <20080313233733.GA4444@implementation> References: <20080305114704.GC9747@implementation.uk.xensource.com> <20080305121802.GD9747@implementation.uk.xensource.com> <20080305135453.GE9786@implementation.uk.xensource.com> <20080313195051.GA17899@volta.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080313195051.GA17899@volta.aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Aurelien Jarno, le Thu 13 Mar 2008 20:50:51 +0100, a écrit : > On Wed, Mar 05, 2008 at 01:54:53PM +0000, Samuel Thibault wrote: > > This fixes SDL mouse events processing: > > - GetRelativeMouseState() always returns the last position, so when the > > polling loop gets several mouse events in one go, we would send > > useless 'no move' events, let's avoid that. > > - So as to make sure we don't miss any mouse click / double click, we > > should not use GetRelativeMouseState() to get the button state, but > > rather keep records of the button state ourselves (I've requested SDL > > developers to provide it directly in the event in SDL 1.3). > > - bev->state doesn't contain the button state but whether the event is a press > > or a release. Use bev->button instead. > > This patch does not apply anymore. Could you please to redo it against > the current CVS? Mmm, well, it actually is conflicting with the "mouse smoothness" patch: the question is: after the 30ms period, if we got several mouse motion events, should we merge them into a single one for the guest, or should we provide all of them (hence making the cursor looking more smooth, but requiring more treatments from the guest)? Samuel