From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JdSv6-0001cz-DL
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 12:19:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JdSv4-0001cm-Pg
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 12:19:39 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JdSv4-0001cj-Jv
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 12:19:38 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JdSv4-0004Vx-AC
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 12:19:38 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general
	support
Date: Sun, 23 Mar 2008 16:19:30 +0000
References: <1206282453.18800.31.camel@localhost.localdomain>
In-Reply-To: <1206282453.18800.31.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200803231619.32472.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, dor.laor@qumranet.com
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>

On Sunday 23 March 2008, Dor Laor wrote:
> --- a/qemu/hw/irq.c
> +++ b/qemu/hw/irq.c
> @@ -30,6 +30,8 @@ struct IRQState {
> =A0 =A0 =A0int n;
> =A0};
> =A0
> +uint32_t qemu_irq_acked[NR_IRQ_WORDS];

This is absolute rubbish. The whole point of the IRQ framework is that it=20
doesn't assume a single flat IRQ controller.

Paul