qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] ide.c make write cacheing controllable by guest
Date: Thu, 27 Mar 2008 18:16:48 +0000	[thread overview]
Message-ID: <200803271816.48996.paul@codesourcery.com> (raw)
In-Reply-To: <18411.57658.233813.764037@mariner.uk.xensource.com>

On Thursday 27 March 2008, Ian Jackson wrote:
>              case 0xcc: /* reverting to power-on defaults enable */
>              case 0x66: /* reverting to power-on defaults disable */
>              case 0x02: /* write cache enable */
> +                s->write_cache = 1;

This look wrong.

Paul

  reply	other threads:[~2008-03-27 18:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 18:02 [Qemu-devel] [PATCH] ide.c make write cacheing controllable by guest Ian Jackson
2008-03-27 18:16 ` Paul Brook [this message]
2008-03-28  9:38   ` Ian Jackson
  -- strict thread matches above, loose matches on Subject: below --
2008-02-25 18:13 Ian Jackson
2008-02-25 20:50 ` Jamie Lokier
2008-02-26  1:16   ` Chris Wedgwood
2008-02-26  7:32     ` Jamie Lokier
2008-02-26 12:15   ` Ian Jackson
2008-02-26 12:49     ` Jamie Lokier
2008-02-26 16:57       ` Ian Jackson
2008-02-26 17:25         ` Jamie Lokier
2008-02-26 18:11           ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803271816.48996.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).