From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Jewen-0001xu-7S
	for qemu-devel@nongnu.org; Thu, 27 Mar 2008 14:16:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Jewem-0001wP-Da
	for qemu-devel@nongnu.org; Thu, 27 Mar 2008 14:16:56 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Jewem-0001wF-9p
	for qemu-devel@nongnu.org; Thu, 27 Mar 2008 14:16:56 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Jewel-0008KV-T1
	for qemu-devel@nongnu.org; Thu, 27 Mar 2008 14:16:56 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] ide.c make write cacheing controllable by
	guest
Date: Thu, 27 Mar 2008 18:16:48 +0000
References: <18411.57658.233813.764037@mariner.uk.xensource.com>
In-Reply-To: <18411.57658.233813.764037@mariner.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200803271816.48996.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>

On Thursday 27 March 2008, Ian Jackson wrote:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0case 0xcc: /* reverting to power-on defaults e=
nable */
> =A0 =A0 =A0 =A0 =A0 =A0 =A0case 0x66: /* reverting to power-on defaults d=
isable */
> =A0 =A0 =A0 =A0 =A0 =A0 =A0case 0x02: /* write cache enable */
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0s->write_cache =3D 1;

This look wrong.

Paul