From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size.
Date: Fri, 28 Mar 2008 11:05:17 +0100 [thread overview]
Message-ID: <20080328100517.GC3979@implementation.orange-hotspot.com> (raw)
In-Reply-To: <20080327235340.GA7964@volta.aurel32.net>
Aurelien Jarno, le Fri 28 Mar 2008 00:53:40 +0100, a écrit :
> > +#define IDE_DMA_BUF_SIZE 131072
>
> Wouldn't it be better to define this value in number of sectors? This
> would avoid a few divisions in the code, and anyway the code handling
> DMA transfers is working with a number of sectors, not a number of
> bytes.
Right.
Samuel
next prev parent reply other threads:[~2008-03-28 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 16:35 [Qemu-devel] [PATCH] Improve DMA transfers by increasing the buffer size Ian Jackson
2008-03-27 23:53 ` Aurelien Jarno
2008-03-28 10:05 ` Samuel Thibault [this message]
2008-03-28 11:35 ` Ian Jackson
2008-03-28 16:22 ` Aurelien Jarno
2008-03-29 12:16 ` Aurelien Jarno
2008-03-31 15:25 ` Ian Jackson
2008-03-30 10:42 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328100517.GC3979@implementation.orange-hotspot.com \
--to=samuel.thibault@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).