From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JfBTK-0008Rk-Ry
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 06:06:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JfBTI-0008OZ-ED
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 06:06:05 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JfBTH-0008O5-G7
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 06:06:04 -0400
Received: from smtp02.citrix.com ([66.165.176.63])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1JfBTG-00081F-Sv
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 06:06:03 -0400
Received: from implementation.famille.thibault.fr ([81.253.20.146])
	(authenticated bits=0)
	by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id m2SA5IBv001390
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO)
	for <qemu-devel@nongnu.org>; Fri, 28 Mar 2008 03:05:20 -0700
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1JfBSX-0001VQ-F0
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 11:05:17 +0100
Date: Fri, 28 Mar 2008 11:05:17 +0100
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] Improve DMA transfers by increasing the
	buffer size.
Message-ID: <20080328100517.GC3979@implementation.orange-hotspot.com>
References: <18410.31540.160387.110544@mariner.uk.xensource.com>
	<20080327235340.GA7964@volta.aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20080327235340.GA7964@volta.aurel32.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Aurelien Jarno, le Fri 28 Mar 2008 00:53:40 +0100, a écrit :
> > +#define IDE_DMA_BUF_SIZE 131072
> 
> Wouldn't it be better to define this value in number of sectors? This
> would avoid a few divisions in the code, and anyway the code handling
> DMA transfers is working with a number of sectors, not a number of 
> bytes.

Right.

Samuel