From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JfHwg-0006FM-Ki
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 13:00:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JfHwf-0006Eb-4g
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 13:00:50 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JfHwe-0006EX-Ki
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 13:00:48 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JfHwd-0005LB-Tg
	for qemu-devel@nongnu.org; Fri, 28 Mar 2008 13:00:48 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [kvm-devel] [Qemu-devel] [PATCH] QEMU: fsync AIO writes on flush
	request
Date: Fri, 28 Mar 2008 17:00:39 +0000
References: <20080328150517.GA18077@dmt>
	<200803281640.55185.paul@codesourcery.com>
	<20080328165941.GA19155@dmt>
In-Reply-To: <20080328165941.GA19155@dmt>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="ansi_x3.4-1968"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200803281700.40420.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <marcelo@kvack.org>, kvm-devel <kvm-devel@lists.sourceforge.net>

> > Surely you should be using the normal aio notification to wait for the
> > aio_fsync to complete before reporting success to the device.
>
> qemu_aio_flush() will wait for all pending AIO requests (including
> aio_fsync) to complete.

Then why do you need to separate fdatasync?

Paul