From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: kvm-devel@lists.sourceforge.net,
Marcelo Tosatti <marcelo@kvack.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 4/6] virtio network driver
Date: Sun, 30 Mar 2008 10:27:07 +0000 [thread overview]
Message-ID: <200803301127.08620.paul@codesourcery.com> (raw)
In-Reply-To: <1206827760-4566-4-git-send-email-aliguori@us.ibm.com>
On Saturday 29 March 2008, Anthony Liguori wrote:
> + if ((elem = virtqueue_pop(n->rx_vq)) == NULL) {
> + /* wait until the guest adds some rx bufs */
> + n->can_receive = 0;
> + return;
> + }
Setting can_receive to zero *after* dropping a packet is a bit late.
Not a fatal flaw, but it does make can_receive fairly useless. The whole point
of can_receive is to workaround lack of proper TCP rate control in the slirp
code.
Paul
next prev parent reply other threads:[~2008-03-30 10:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 21:55 [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] [PATCH 2/6] PCI DMA API Anthony Liguori
2008-03-30 7:06 ` Blue Swirl
2008-03-30 14:44 ` Anthony Liguori
2008-03-30 14:49 ` Avi Kivity
2008-03-30 14:56 ` [kvm-devel] " Anthony Liguori
2008-03-30 14:58 ` Blue Swirl
2008-03-30 15:11 ` Anthony Liguori
2008-03-30 10:18 ` Paul Brook
2008-03-30 14:42 ` Anthony Liguori
2008-03-30 18:19 ` Paul Brook
2008-03-30 19:02 ` Anthony Liguori
2008-03-30 10:25 ` [Qemu-devel] Re: [kvm-devel] " Avi Kivity
2008-03-30 14:49 ` Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] [PATCH 3/6] virtio for QEMU Anthony Liguori
2008-03-30 17:25 ` Dor Laor
2008-03-30 22:59 ` [kvm-devel] " Anthony Liguori
2008-04-05 3:09 ` Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] [PATCH 4/6] virtio network driver Anthony Liguori
2008-03-30 10:27 ` Paul Brook [this message]
2008-03-30 14:47 ` Anthony Liguori
2008-03-29 21:55 ` [Qemu-devel] [PATCH 5/6] virtio block driver Anthony Liguori
2008-03-29 21:56 ` [Qemu-devel] [PATCH 6/6] virtio balloon driver Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803301127.08620.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=kvm-devel@lists.sourceforge.net \
--cc=marcelo@kvack.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).