From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Asynchronous reliable and configurable cache flush
Date: Tue, 1 Apr 2008 19:07:46 +0100 [thread overview]
Message-ID: <20080401180746.GB5030@implementation> (raw)
In-Reply-To: <18418.28291.689482.198484@mariner.uk.xensource.com>
Hello,
Oh, by the way, shouldn't this:
Ian Jackson, le Tue 01 Apr 2008 18:18:59 +0100, a écrit :
> put_le16(p + 81, 0x16); /* conforms to ata5 */
> - put_le16(p + 82, (1 << 14));
> + /* 14=nop 5=write_cache */
> + put_le16(p + 82, (1 << 14) | (1 << 5));
> /* 13=flush_cache_ext,12=flush_cache,10=lba48 */
use s->write_cache instead of always 1? Else when using hdparm -i one
would think that write cache is always enabled.
Samuel
next prev parent reply other threads:[~2008-04-01 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 17:18 [Qemu-devel] [PATCH] Asynchronous reliable and configurable cache flush Ian Jackson
2008-04-01 17:46 ` Paul Brook
2008-04-01 18:45 ` Jamie Lokier
2008-04-02 12:26 ` Paul Brook
2008-04-02 15:23 ` Jamie Lokier
2008-04-02 16:20 ` Ian Jackson
2008-04-03 11:38 ` Jamie Lokier
2008-04-03 12:06 ` Ian Jackson
2008-04-02 16:27 ` Ian Jackson
2008-04-03 0:40 ` Paul Brook
2008-04-03 10:00 ` Ian Jackson
2008-04-01 18:07 ` Samuel Thibault [this message]
2008-04-02 14:21 ` Ian Jackson
2008-04-04 14:29 ` Samuel Thibault
2008-04-02 16:31 ` [Qemu-devel] " Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080401180746.GB5030@implementation \
--to=samuel.thibault@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).