From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Jgkto-0002Cw-41
	for qemu-devel@nongnu.org; Tue, 01 Apr 2008 14:07:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Jgkti-0002Cb-Ia
	for qemu-devel@nongnu.org; Tue, 01 Apr 2008 14:07:54 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Jgkti-0002CX-Ff
	for qemu-devel@nongnu.org; Tue, 01 Apr 2008 14:07:50 -0400
Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1Jgkth-0005ud-Uc
	for qemu-devel@nongnu.org; Tue, 01 Apr 2008 14:07:50 -0400
Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout03-winn.ispmail.ntl.com with ESMTP id
	<20080401181123.NUGW271.mtaout03-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Tue, 1 Apr 2008 19:11:23 +0100
Received: from implementation.famille.thibault.fr ([82.21.96.230])
	by aamtaout02-winn.ispmail.ntl.com with ESMTP id
	<20080401180949.ENRG17393.aamtaout02-winn.ispmail.ntl.com@implementation.famille.thibault.fr>
	for <qemu-devel@nongnu.org>; Tue, 1 Apr 2008 19:09:49 +0100
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1Jgkte-0001Pr-U1
	for qemu-devel@nongnu.org; Tue, 01 Apr 2008 20:07:46 +0200
Date: Tue, 1 Apr 2008 19:07:46 +0100
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] Asynchronous reliable and configurable cache
	flush
Message-ID: <20080401180746.GB5030@implementation>
References: <18418.28291.689482.198484@mariner.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <18418.28291.689482.198484@mariner.uk.xensource.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hello,

Oh, by the way, shouldn't this:

Ian Jackson, le Tue 01 Apr 2008 18:18:59 +0100, a écrit :
>      put_le16(p + 81, 0x16); /* conforms to ata5 */
> -    put_le16(p + 82, (1 << 14));
> +    /* 14=nop 5=write_cache */
> +    put_le16(p + 82, (1 << 14) | (1 << 5));
>      /* 13=flush_cache_ext,12=flush_cache,10=lba48 */

use s->write_cache instead of always 1?  Else when using hdparm -i one
would think that write cache is always enabled.

Samuel