From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <marcelo@kvack.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2)
Date: Sun, 6 Apr 2008 22:41:07 -0500 [thread overview]
Message-ID: <200804062241.08188.paul@codesourcery.com> (raw)
In-Reply-To: <1207368175-19476-1-git-send-email-aliguori@us.ibm.com>
On Friday 04 April 2008 23:02:50 Anthony Liguori wrote:
> uint32_t is the wrong type to use to represent physical addresses.
>....
> /* XXX: temporary until new memory mapping API */
> -uint32_t cpu_get_physical_page_desc(target_phys_addr_t addr)
> +ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr)
The returned value is still a uint32_t. Changing the function prototype
without fixing that is just deluding yourself.
Paul
next prev parent reply other threads:[~2008-04-07 3:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 4:02 [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] [PATCH 2/6] PCI DMA API (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] [PATCH 3/6] virtio for QEMU (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] [PATCH 4/6] virtio network driver (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] [PATCH 5/6] virtio block " Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] [PATCH 6/6] virtio balloon " Anthony Liguori
2008-04-06 6:57 ` [Qemu-devel] [PATCH 2/6] PCI DMA API (v2) Blue Swirl
2008-04-06 15:22 ` [kvm-devel] " Anthony Liguori
2008-04-06 17:01 ` andrzej zaborowski
2008-04-06 17:46 ` Anthony Liguori
2008-04-07 0:40 ` Paul Brook
2008-04-07 8:32 ` andrzej zaborowski
2008-04-07 15:44 ` Paul Brook
2008-04-07 3:41 ` Paul Brook [this message]
2008-04-07 13:22 ` [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2) Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804062241.08188.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=marcelo@kvack.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).