From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JiiFi-0000Rr-6m
	for qemu-devel@nongnu.org; Sun, 06 Apr 2008 23:42:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JiiFg-0000Pc-Ce
	for qemu-devel@nongnu.org; Sun, 06 Apr 2008 23:42:37 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JiiFg-0000PN-6K
	for qemu-devel@nongnu.org; Sun, 06 Apr 2008 23:42:36 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JiiFf-0002AN-JM
	for qemu-devel@nongnu.org; Sun, 06 Apr 2008 23:42:35 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] Use ram_addr_t for
	cpu_get_physical_page_desc (v2)
Date: Sun, 6 Apr 2008 22:41:07 -0500
References: <1207368175-19476-1-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1207368175-19476-1-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200804062241.08188.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <marcelo@kvack.org>, Anthony Liguori <aliguori@us.ibm.com>, Aurelien Jarno <aurelien@aurel32.net>

On Friday 04 April 2008 23:02:50 Anthony Liguori wrote:
> uint32_t is the wrong type to use to represent physical addresses.
>....
>  /* XXX: temporary until new memory mapping API */
> -uint32_t cpu_get_physical_page_desc(target_phys_addr_t addr)
> +ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr)

The returned value is still a uint32_t. Changing the function prototype 
without fixing that is just deluding yourself.

Paul