[Qemu-devel] [PATCH] configure target_list cleanup

[Qemu-devel] [PATCH] configure target_list cleanup

[Stuart Brady]

Hi,

The included patch splits the setting of target_list into one line for
each target, so that any changes to this list are easier to examine,
and to avoid merge conflicts.

Incidentally, the new ordering makes it easier to determine the progress
of a build, based on the name of the target that is currently building.

diff -urN qemu-orig/configure qemu-new/configure
--- qemu-orig/configure	2008-04-12 03:35:12.000000000 +0100
+++ qemu-new/configure	2008-04-12 02:51:27.000000000 +0100
@@ -536,16 +536,47 @@
 if test -z "$target_list" ; then
 # these targets are portable
     if [ "$softmmu" = "yes" ] ; then
-        target_list="i386-softmmu sparc-softmmu x86_64-softmmu mips-softmmu mipsel-softmmu mips64-softmmu mips64el-softmmu arm-softmmu ppc-softmmu ppcemb-softmmu ppc64-softmmu m68k-softmmu sh4-softmmu sh4eb-softmmu cris-softmmu"
+	target_list="$target_list i386-softmmu"
+	target_list="$target_list x86_64-softmmu"
+	target_list="$target_list arm-softmmu"
+	target_list="$target_list cris-softmmu"
+	target_list="$target_list m68k-softmmu"
+	target_list="$target_list mips-softmmu"
+	target_list="$target_list mipsel-softmmu"
+	target_list="$target_list mips64-softmmu"
+	target_list="$target_list mips64el-softmmu"
+	target_list="$target_list ppc-softmmu"
+	target_list="$target_list ppcemb-softmmu"
+	target_list="$target_list ppc64-softmmu"
+	target_list="$target_list sh4-softmmu"
+	target_list="$target_list sh4eb-softmmu"
+	target_list="$target_list sparc-softmmu"
     fi
 # the following are Linux specific
     if [ "$linux_user" = "yes" ] ; then
-        target_list="i386-linux-user arm-linux-user armeb-linux-user sparc-linux-user sparc64-linux-user sparc32plus-linux-user mips-linux-user mipsel-linux-user m68k-linux-user alpha-linux-user sh4-linux-user sh4eb-linux-user ppc-linux-user ppc64-linux-user ppc64abi32-linux-user x86_64-linux-user cris-linux-user $target_list"
+	target_list="$target_list i386-linux-user"
+	target_list="$target_list x86_64-linux-user"
+	target_list="$target_list alpha-linux-user"
+	target_list="$target_list arm-linux-user"
+	target_list="$target_list armeb-linux-user"
+	target_list="$target_list cris-linux-user"
+	target_list="$target_list m68k-linux-user"
+	target_list="$target_list mips-linux-user"
+	target_list="$target_list mipsel-linux-user"
+	target_list="$target_list ppc-linux-user"
+	target_list="$target_list ppc64-linux-user"
+	target_list="$target_list ppc64abi32-linux-user"
+	target_list="$target_list sh4-linux-user"
+	target_list="$target_list sh4eb-linux-user"
+	target_list="$target_list sparc-linux-user"
+	target_list="$target_list sparc64-linux-user"
+	target_list="$target_list sparc32plus-linux-user"
     fi
 # the following are Darwin specific
     if [ "$darwin_user" = "yes" ] ; then
-        target_list="i386-darwin-user ppc-darwin-user $target_list"
+	target_list="$target_list i386-darwin-user ppc-darwin-user"
     fi
+    target_list=`echo "$target_list" | sed -e 's/^ //g'`
 else
     target_list=`echo "$target_list" | sed -e 's/,/ /g'`
 fi

Cheers,
-- 
Stuart Brady

Re: [Qemu-devel] [PATCH] configure target_list cleanup

[Stuart Brady]

On Sat, Apr 12, 2008 at 03:51:23AM +0100, Stuart Brady wrote:
> The included patch splits the setting of target_list into one line for
> each target, so that any changes to this list are easier to examine,
> and to avoid merge conflicts.

I'll submit a better version of this patch shortly, possibly with some
additional cleanups -- adding some case statements, etc.

Cheers,
-- 
Stuart Brady