qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure cleanup
Date: Sat, 12 Apr 2008 14:41:15 +0100	[thread overview]
Message-ID: <200804121441.16416.paul@codesourcery.com> (raw)
In-Reply-To: <20080411192401.GA30794@miranda.arrow>

> The included patch rearranges the configure script slightly, to reduce
> future merge conflicts and to make it easier to read diffs for changes
> to the script that add support extra host/target architectures/ABIs.

IMHO things like this are better expressed as switch statements. We already 
have such a switch statement a few pages above for ARCH_CFLAGS. It seems like 
these and the subsequent hostlongbits could be combined.

Paul

  parent reply	other threads:[~2008-04-12 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 19:24 [Qemu-devel] [PATCH] configure cleanup Stuart Brady
2008-04-11 21:20 ` [Qemu-devel] [PATCH] configure cleanup [v2] Stuart Brady
2008-04-12 13:41 ` Paul Brook [this message]
2008-04-12 15:20   ` [Qemu-devel] [PATCH] configure cleanup Stuart Brady
2008-04-12 16:29     ` Andreas Schwab
2008-04-12 17:13       ` Stuart Brady
2008-04-12 18:52         ` Andreas Schwab
2008-04-12 19:01           ` Stuart Brady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804121441.16416.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).