From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JkfzP-0007Wb-Ob for qemu-devel@nongnu.org; Sat, 12 Apr 2008 09:41:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JkfzK-0007W0-BL for qemu-devel@nongnu.org; Sat, 12 Apr 2008 09:41:54 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JkfzK-0007Vr-4r for qemu-devel@nongnu.org; Sat, 12 Apr 2008 09:41:50 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JkfzH-0007G5-Gf for qemu-devel@nongnu.org; Sat, 12 Apr 2008 09:41:49 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] configure cleanup Date: Sat, 12 Apr 2008 14:41:15 +0100 References: <20080411192401.GA30794@miranda.arrow> In-Reply-To: <20080411192401.GA30794@miranda.arrow> MIME-Version: 1.0 Content-Type: text/plain; charset="ansi_x3.4-1968" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804121441.16416.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org > The included patch rearranges the configure script slightly, to reduce > future merge conflicts and to make it easier to read diffs for changes > to the script that add support extra host/target architectures/ABIs. IMHO things like this are better expressed as switch statements. We already have such a switch statement a few pages above for ARCH_CFLAGS. It seems like these and the subsequent hostlongbits could be combined. Paul