qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] SDL: Fix dead keys
Date: Sat, 12 Apr 2008 20:30:04 +0100	[thread overview]
Message-ID: <20080412193004.GK4412@implementation> (raw)

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hello,

On a lot of keyboards (e.g. french, finnish, ...), there are dead keys,
i.e. they don't output text alone.  Qemu's sdl.c always enable unicode
mode, so that these keys don't actually produce a keycode, and the
result is that these keys don't work at all in the guest.  The attached
patch fixes that by enabling/disabling unicode mode as needed.

Samuel

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 530 bytes --]

Index: sdl.c
===================================================================
--- sdl.c	(r�vision 4173)
+++ sdl.c	(copie de travail)
@@ -352,6 +352,7 @@
     }
 
     vga_hw_update();
+    SDL_EnableUNICODE(!is_graphic_console());
 
     while (SDL_PollEvent(ev)) {
         switch (ev->type) {
@@ -640,7 +641,6 @@
     sdl_resize(ds, 640, 400);
     sdl_update_caption();
     SDL_EnableKeyRepeat(250, 50);
-    SDL_EnableUNICODE(1);
     gui_grab = 0;
 
     sdl_cursor_hidden = SDL_CreateCursor(&data, &data, 8, 1, 0, 0);

                 reply	other threads:[~2008-04-12 19:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080412193004.GK4412@implementation \
    --to=samuel.thibault@ens-lyon.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).