From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JklQU-0001D3-3x
	for qemu-devel@nongnu.org; Sat, 12 Apr 2008 15:30:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JklQS-0001CB-9o
	for qemu-devel@nongnu.org; Sat, 12 Apr 2008 15:30:13 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JklQS-0001C4-31
	for qemu-devel@nongnu.org; Sat, 12 Apr 2008 15:30:12 -0400
Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1JklQR-0003LK-JB
	for qemu-devel@nongnu.org; Sat, 12 Apr 2008 15:30:11 -0400
Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout01-winn.ispmail.ntl.com with ESMTP id
	<20080412193306.DRZC13584.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Sat, 12 Apr 2008 20:33:06 +0100
Received: from implementation.famille.thibault.fr ([82.21.96.230])
	by aamtaout01-winn.ispmail.ntl.com with ESMTP id
	<20080412193407.DUAS219.aamtaout01-winn.ispmail.ntl.com@implementation.famille.thibault.fr>
	for <qemu-devel@nongnu.org>; Sat, 12 Apr 2008 20:34:07 +0100
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1JklQM-0002kp-3A
	for qemu-devel@nongnu.org; Sat, 12 Apr 2008 21:30:06 +0200
Date: Sat, 12 Apr 2008 20:30:04 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-ID: <20080412193004.GK4412@implementation>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ibTvN161/egqYuK8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH] SDL: Fix dead keys
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


--ibTvN161/egqYuK8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello,

On a lot of keyboards (e.g. french, finnish, ...), there are dead keys,
i.e. they don't output text alone.  Qemu's sdl.c always enable unicode
mode, so that these keys don't actually produce a keycode, and the
result is that these keys don't work at all in the guest.  The attached
patch fixes that by enabling/disabling unicode mode as needed.

Samuel

--ibTvN161/egqYuK8
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment; filename=patch
Content-Transfer-Encoding: 8bit

Index: sdl.c
===================================================================
--- sdl.c	(r�vision 4173)
+++ sdl.c	(copie de travail)
@@ -352,6 +352,7 @@
     }
 
     vga_hw_update();
+    SDL_EnableUNICODE(!is_graphic_console());
 
     while (SDL_PollEvent(ev)) {
         switch (ev->type) {
@@ -640,7 +641,6 @@
     sdl_resize(ds, 640, 400);
     sdl_update_caption();
     SDL_EnableKeyRepeat(250, 50);
-    SDL_EnableUNICODE(1);
     gui_grab = 0;
 
     sdl_cursor_hidden = SDL_CreateCursor(&data, &data, 8, 1, 0, 0);

--ibTvN161/egqYuK8--