From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JlOTr-0004fl-LI for qemu-devel@nongnu.org; Mon, 14 Apr 2008 09:12:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JlOTp-0004da-Q4 for qemu-devel@nongnu.org; Mon, 14 Apr 2008 09:12:19 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JlOTp-0004dD-H5 for qemu-devel@nongnu.org; Mon, 14 Apr 2008 09:12:17 -0400 Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JlOTp-0000Gj-83 for qemu-devel@nongnu.org; Mon, 14 Apr 2008 09:12:17 -0400 Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout03-winn.ispmail.ntl.com with ESMTP id <20080414131607.PMMH11232.mtaout03-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com> for ; Mon, 14 Apr 2008 14:16:07 +0100 Received: from miranda.arrow ([213.107.26.151]) by aamtaout02-winn.ispmail.ntl.com with ESMTP id <20080414131424.QEAQ17393.aamtaout02-winn.ispmail.ntl.com@miranda.arrow> for ; Mon, 14 Apr 2008 14:14:24 +0100 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1JlOTh-00019q-GN for qemu-devel@nongnu.org; Mon, 14 Apr 2008 14:12:09 +0100 Date: Mon, 14 Apr 2008 14:12:09 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] Re: [RFC][PATCH 4/4] Add support for Marvell 88w8618 / MusicPal Message-ID: <20080414131209.GA4420@miranda.arrow> References: <4801DC59.1010403@web.de> <480300D2.2060400@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480300D2.2060400@web.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Apr 14, 2008 at 08:59:30AM +0200, Jan Kiszka wrote: > malc wrote: > > Zero is not correct "mute" value for signed formats. > > Hmm, maybe it's still too early for me - but what else?? Well, zero is not correct for unsigned formats, but I cannot see any such formats in use in your emulation... BTW, there are quite a few magic constants that it would probably be better to #define. Cheers, -- Stuart Brady