From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jnijt-0002lP-Mg for qemu-devel@nongnu.org; Sun, 20 Apr 2008 19:14:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jnijr-0002ja-SL for qemu-devel@nongnu.org; Sun, 20 Apr 2008 19:14:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jnijr-0002j5-4D for qemu-devel@nongnu.org; Sun, 20 Apr 2008 19:14:27 -0400 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jnijp-0007Pd-EN for qemu-devel@nongnu.org; Sun, 20 Apr 2008 19:14:25 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3KNEJex021085 for ; Sun, 20 Apr 2008 19:14:19 -0400 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3KNEIU9014893 for ; Sun, 20 Apr 2008 19:14:19 -0400 Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id m3KNEIYA031569 for qemu-devel@nongnu.org; Mon, 21 Apr 2008 00:14:18 +0100 Date: Mon, 21 Apr 2008 00:14:18 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] Add -display option Message-ID: <20080420231418.GA30932@redhat.com> References: <4804589A.6040300@reactos.org> <00f701c8a329$97af64e0$0201a8c0@zeug> <480BBD37.5010409@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480BBD37.5010409@codemonkey.ws> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Apr 20, 2008 at 05:01:27PM -0500, Anthony Liguori wrote: > Sebastian Herbszt wrote: > >>I would better name it -display, as not all computers have > >>VGA-compatible cards. > >+ break; > >+ case QEMU_OPTION_display: > >+ if (!strcmp(optarg, "cirrus")) { > >+ cirrus_vga_enabled = 1; > >+ vmsvga_enabled = 0; > >+ } else if (!strcmp(optarg, "std")) { > >+ cirrus_vga_enabled = 0; > >+ vmsvga_enabled = 0; > >+ } else if (!strcmp(optarg, "vmware")) { > >+ cirrus_vga_enabled = 0; > >+ vmsvga_enabled = 1; > >+ } else if (!strcmp(optarg, "none")) { > >+ serial_devices[0] = "stdio"; > >+ parallel_devices[0] = "null"; > >+ monitor_device = "stdio"; > >+ nographic = 1; > > I don't think -display none should be a synonym for -nographic. It > should just suppress the creation of a VGA device. If a platform > doesn't support that, it should raise an error. I agree - its rather unfortunate that -nographic changes the default settings for serial / parallel devices - it makes it troublesome to launch QEMU with a predictable config. Having 'none' merely supress the VGA device would be preferrable behaviour. It is certainly nice from a libvirt point of view to have a generic flag -display like this. Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|