[Qemu-devel] [PATCH] cpu_physical_memory_rw typo

[Qemu-devel] [PATCH] cpu_physical_memory_rw typo

[Samuel Thibault]

[-- Attachment #1: Type: text/plain, Size: 137 bytes --]

Hello,

It looks like there was a typo in cpu_physical_memory_rw: the loop is
supposed to copy only l bytes, not len, see patch.

Samuel

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1235 bytes --]

Index: exec.c
===================================================================
--- exec.c	(révision 4233)
+++ exec.c	(copie de travail)
@@ -2540,20 +2540,20 @@
             if (!(flags & PAGE_WRITE))
                 return;
             /* XXX: this code should not depend on lock_user */
-            if (!(p = lock_user(VERIFY_WRITE, addr, len, 0)))
+            if (!(p = lock_user(VERIFY_WRITE, addr, l, 0)))
                 /* FIXME - should this return an error rather than just fail? */
                 return;
-            memcpy(p, buf, len);
-            unlock_user(p, addr, len);
+            memcpy(p, buf, l);
+            unlock_user(p, addr, l);
         } else {
             if (!(flags & PAGE_READ))
                 return;
             /* XXX: this code should not depend on lock_user */
-            if (!(p = lock_user(VERIFY_READ, addr, len, 1)))
+            if (!(p = lock_user(VERIFY_READ, addr, l, 1)))
                 /* FIXME - should this return an error rather than just fail? */
                 return;
-            memcpy(buf, p, len);
-            unlock_user(p, addr, 0);
+            memcpy(buf, p, l);
+            unlock_user(p, addr, l);
         }
         len -= l;
         buf += l;