From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [4239] x86/x86-64 MMU PAE fixes
Date: Tue, 22 Apr 2008 21:57:12 +0100 [thread overview]
Message-ID: <200804222157.12963.paul@codesourcery.com> (raw)
In-Reply-To: <E1JoPFI-0006oi-2m@cvs.savannah.gnu.org>
On Tuesday 22 April 2008, Aurelien Jarno wrote:
> -#define PHYS_ADDR_MASK 0xfffff000
> +#define PHYS_ADDR_MASK (~0xfff)
I think this is wrong. According to my docs physical addresses have an
architectural limit of 52 bits. Bits 52-62 of a PTE are reserved (must be
zero), and bit 63 is the NX bit.
You already reverted the following, but I'm going to mention it anyway:
> -#elif defined(TARGET_X86_64) && !defined(USE_KQEMU)
> -#define TARGET_PHYS_ADDR_SPACE_BITS 40
I think this should either be 52, or cpu specific.
Paul
next prev parent reply other threads:[~2008-04-22 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 20:37 [Qemu-devel] [4239] x86/x86-64 MMU PAE fixes Aurelien Jarno
2008-04-22 20:57 ` Paul Brook [this message]
2008-04-22 22:19 ` Stuart Brady
2008-04-22 22:29 ` Paul Brook
2008-04-22 22:37 ` Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804222157.12963.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).