From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JoPYi-0004Tl-Q8
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 16:57:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JoPYe-0004Sc-Fe
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 16:57:48 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JoPYe-0004SY-9E
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 16:57:44 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JoPYd-0000Db-Pa
	for qemu-devel@nongnu.org; Tue, 22 Apr 2008 16:57:44 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [4239] x86/x86-64 MMU PAE fixes
Date: Tue, 22 Apr 2008 21:57:12 +0100
References: <E1JoPFI-0006oi-2m@cvs.savannah.gnu.org>
In-Reply-To: <E1JoPFI-0006oi-2m@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200804222157.12963.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>

On Tuesday 22 April 2008, Aurelien Jarno wrote:
> -#define PHYS_ADDR_MASK 0xfffff000
> +#define PHYS_ADDR_MASK (~0xfff)

I think this is wrong. According to my docs physical addresses have an 
architectural limit of 52 bits. Bits 52-62 of a PTE are reserved (must be 
zero), and bit 63 is the NX bit.

You already reverted the following, but I'm going to mention it anyway:

> -#elif defined(TARGET_X86_64) && !defined(USE_KQEMU)
> -#define TARGET_PHYS_ADDR_SPACE_BITS 40

I think this should either be 52, or cpu specific.

Paul