From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JpSHY-0005Qq-I2
	for qemu-devel@nongnu.org; Fri, 25 Apr 2008 14:04:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JpSHU-0005QV-Ku
	for qemu-devel@nongnu.org; Fri, 25 Apr 2008 14:04:24 -0400
Received: from [199.232.76.173] (port=45952 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JpSHU-0005QR-Fs
	for qemu-devel@nongnu.org; Fri, 25 Apr 2008 14:04:20 -0400
Received: from smtp.eu.citrix.com ([62.200.22.115])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1JpSHT-0005op-Mw
	for qemu-devel@nongnu.org; Fri, 25 Apr 2008 14:04:20 -0400
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1JpSHG-0003G0-Dh
	for qemu-devel@nongnu.org; Fri, 25 Apr 2008 20:04:06 +0200
Date: Fri, 25 Apr 2008 19:04:06 +0100
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Message-ID: <20080425180406.GG4279@implementation.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: [Qemu-devel] VGA 2bit mode
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hello,

I don't have a VGA book right here to check, but I don't understand
vga_draw_line2_:

	d += BPP * 8;
        s += 4;

i.e. 4 bytes for 8 pixels and vga_draw_line4_:

	d += BPP * 8;
        s += 4;

i.e. 4 bytes for 8 pixels too. Does VGA 2bit mode voluntarily waste
memory?

Samuel