From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JpqWz-0005EI-91 for qemu-devel@nongnu.org; Sat, 26 Apr 2008 15:57:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JpqWx-0005Bx-HT for qemu-devel@nongnu.org; Sat, 26 Apr 2008 15:57:56 -0400 Received: from [199.232.76.173] (port=35463 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JpqWx-0005Bc-9Q for qemu-devel@nongnu.org; Sat, 26 Apr 2008 15:57:55 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JpqWw-000192-Mh for qemu-devel@nongnu.org; Sat, 26 Apr 2008 15:57:55 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [4261] Errors while registering ioports are not fatal (Glauber Costa). Date: Sat, 26 Apr 2008 20:57:50 +0100 References: <200804262026.06396.paul@codesourcery.com> <4813844C.7070308@codemonkey.ws> In-Reply-To: <4813844C.7070308@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804262057.51230.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Saturday 26 April 2008, Anthony Liguori wrote: > Paul Brook wrote: > > On Saturday 26 April 2008, Andrzej Zaborowski wrote: > >> Revision: 4261 > >> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4261 > >> Author: balrog > >> Date: 2008-04-26 16:04:29 +0000 (Sat, 26 Apr 2008) > >> > >> Log Message: > >> ----------- > >> Errors while registering ioports are not fatal (Glauber Costa). > > > > Why shouldn't they be fatal? How can this be anything other than a > > serious bug in the device emulation? > > I think the idea is that the device should fail to initialize rather the > VM being destroyed. Consider the case of PCI hotplug. It's a > recoverable error if register ioport fails during hot add. The errors that get suppressed aren't the sort of thing that should ever happen. How exactly do you end up with an IO port that is not 1, 2 or 4 bytes in size? If this ever happens I want qemu do die right there and then. This isn't just a failure, it is an indication that something is broken beyond hope. Paul