From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: silence test for brlapi
Date: Sat, 3 May 2008 12:48:22 +0100 [thread overview]
Message-ID: <20080503114822.GC8032@implementation> (raw)
In-Reply-To: <cef699d70805030442w3e655af9xab8a4245e3dfc0b2@mail.gmail.com>
Ben Taylor, le Sat 03 May 2008 07:42:54 -0400, a écrit :
> On Solaris, I found that the configure code tested the 32-bit bit version
> while on 64-bit, and then it failed linking qemu-img, because Sun didn't
> deliver a 64-bit version of libbrlapi.
>
> Adding ${ARCH_CFLAGS} to the test caused it to do the right thing.
Oh, you mean the patch below?
Samuel
Index: configure
===================================================================
--- configure (révision 4294)
+++ configure (copie de travail)
@@ -733,7 +733,7 @@
#include <brlapi.h>
int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
EOF
- if $cc -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log ; then
+ if $cc ${ARCH_CFLAGS} -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log ; then
brlapi=yes
fi # brlapi compile test
fi # -z $brlapi
next prev parent reply other threads:[~2008-05-03 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 8:39 [Qemu-devel] [PATCH] configure: silence test for brlapi Carlo Marcelo Arenas Belon
2008-05-03 9:34 ` Samuel Thibault
2008-05-03 11:42 ` Ben Taylor
2008-05-03 11:48 ` Samuel Thibault [this message]
2008-05-03 13:35 ` Ben Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503114822.GC8032@implementation \
--to=samuel.thibault@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).