From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jsyw2-00067J-Qs for qemu-devel@nongnu.org; Mon, 05 May 2008 07:32:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jsyw0-00066s-8n for qemu-devel@nongnu.org; Mon, 05 May 2008 07:32:45 -0400 Received: from [199.232.76.173] (port=60438 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jsyw0-00066l-2B for qemu-devel@nongnu.org; Mon, 05 May 2008 07:32:44 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jsyvz-0001i8-Jq for qemu-devel@nongnu.org; Mon, 05 May 2008 07:32:43 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Qemu 32-bit i386, gcc >= 3.4 spill error fix Date: Mon, 5 May 2008 12:32:34 +0100 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805051232.35073.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sunday 04 May 2008, Ben Taylor wrote: > This patch applies some additional flags to op.c and helper.c > for compiling on i386 32-bit systems with gcc >= 3.4. > > This has been tested on both ubuntu 7.10/32-bit and > Solaris SXCE/32-bit with both gcc-3.3 and gcc-3.4 > and the behavior is consistent between both. These hacks are sufficient fickle, and gcc versions sufficiently meaningless[1], that I don't think we should do this. If you really want to fix this, do it properly and finish the TCG conversion. Paul [1] As with most open source software a version number does not uniquely identify a binary. In my experience pretty much noone uses unpatched FSF releases directly.