From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JtMK6-0005sh-Ty
	for qemu-devel@nongnu.org; Tue, 06 May 2008 08:31:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JtMK5-0005s1-Fs
	for qemu-devel@nongnu.org; Tue, 06 May 2008 08:31:10 -0400
Received: from [199.232.76.173] (port=44273 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JtMK5-0005ry-7O
	for qemu-devel@nongnu.org; Tue, 06 May 2008 08:31:09 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JtMK4-0003oQ-K3
	for qemu-devel@nongnu.org; Tue, 06 May 2008 08:31:08 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [4351] Make the paged properties of the tb-jmp-cache
	hash function work for TARGET_PAGE_BITS ! = 12.
Date: Tue, 6 May 2008 13:31:02 +0100
References: <E1JtIgp-0005aV-20@cvs.savannah.gnu.org>
In-Reply-To: <E1JtIgp-0005aV-20@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200805061331.03281.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

>  {
>      target_ulong tmp;
>      tmp = pc ^ (pc >> (TARGET_PAGE_BITS - TB_JMP_PAGE_BITS));
> -    return (tmp >> TB_JMP_PAGE_BITS) & TB_JMP_PAGE_MASK;
> +    return (tmp >> (TARGET_PAGE_BITS - TB_JMP_PAGE_BITS)) &
> TB_JMP_PAGE_MASK; }


I'm not sure what you're trying to achieve here, but this is definitely wrong.
TARGET_PAGE_BITS may be less than TB_JMP_PAGE_BITS.

Paul