From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
Subject: Re: [Qemu-devel] [4351] Make the paged properties of the tb-jmp-cache hash function work for TARGET_PAGE_BITS ! = 12.
Date: Tue, 6 May 2008 15:18:25 +0100 [thread overview]
Message-ID: <200805061518.25575.paul@codesourcery.com> (raw)
In-Reply-To: <20080506140310.GG26816@edgar.se.axis.com>
> > > - return (tmp >> TB_JMP_PAGE_BITS) & TB_JMP_PAGE_MASK;
> > > + return (tmp >> (TARGET_PAGE_BITS - TB_JMP_PAGE_BITS)) &
> > > TB_JMP_PAGE_MASK; }
> >
> > I'm not sure what you're trying to achieve here, but this is definitely
> > wrong. TARGET_PAGE_BITS may be less than TB_JMP_PAGE_BITS.
>
> I didn't find any page bits under 10 in the tree.
Oops, sorry, my bad. I read TB_JMP_PAGE_BITS as TB_JMP_CACHE_BITS-1, not /2.
Paul
prev parent reply other threads:[~2008-05-06 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 8:38 [Qemu-devel] [4351] Make the paged properties of the tb-jmp-cache hash function work for TARGET_PAGE_BITS ! = 12 Edgar E. Iglesias
2008-05-06 12:31 ` Paul Brook
2008-05-06 14:03 ` Edgar E. Iglesias
2008-05-06 14:18 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805061518.25575.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=edgar.iglesias@axis.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).