From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JuDfc-00052z-Mh for qemu-devel@nongnu.org; Thu, 08 May 2008 17:28:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JuDfb-00052T-Vy for qemu-devel@nongnu.org; Thu, 08 May 2008 17:28:56 -0400 Received: from [199.232.76.173] (port=58217 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JuDfb-00052G-PZ for qemu-devel@nongnu.org; Thu, 08 May 2008 17:28:55 -0400 Received: from hall.aurel32.net ([91.121.138.14]:40563) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JuDfZ-0002Kb-MA for qemu-devel@nongnu.org; Thu, 08 May 2008 17:28:54 -0400 Received: from volta.aurel32.net ([2002:52e8:2fb:1:21e:8cff:feb0:693b]) by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JuDfQ-0000oh-EW for qemu-devel@nongnu.org; Thu, 08 May 2008 23:28:44 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1JuDfQ-0004tk-NR for qemu-devel@nongnu.org; Thu, 08 May 2008 23:28:44 +0200 Date: Thu, 8 May 2008 23:28:44 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [4380] CRIS: Disable softfloat and dyngen ops. Message-ID: <20080508212844.GA8314@volta.aurel32.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, May 07, 2008 at 03:33:57PM +0000, Edgar E. Iglesias wrote: > Revision: 4380 > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4380 > Author: edgar_igl > Date: 2008-05-07 15:33:57 +0000 (Wed, 07 May 2008) > > Log Message: > ----------- > CRIS: Disable softfloat and dyngen ops. > I guess that's because CRIS has not FP instructions. In that case the #include "softfloat.h" in target-cris/cpu.h can probably be removed. I tried, but that fail. I guess the patch below should be the correct way to do that. cpu-all.h needs this include as it uses float32, float64 and float128 are used in various parts of this file. diff --git a/cpu-all.h b/cpu-all.h index 2740da9..14e2a88 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -38,6 +38,7 @@ */ #include "bswap.h" +#include "softfloat.h" #if defined(WORDS_BIGENDIAN) != defined(TARGET_WORDS_BIGENDIAN) #define BSWAP_NEEDED diff --git a/target-cris/cpu.h b/target-cris/cpu.h index b62c537..49de830 100644 --- a/target-cris/cpu.h +++ b/target-cris/cpu.h @@ -25,8 +25,6 @@ #include "cpu-defs.h" -#include "softfloat.h" - #define TARGET_HAS_ICE 1 #define ELF_MACHINE EM_CRIS -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net