* [Qemu-devel] [RFC][PATCH] Use HOST_CC instead of CC on TCG only targets
@ 2008-05-08 22:44 Aurelien Jarno
2008-05-08 22:56 ` Paul Brook
0 siblings, 1 reply; 2+ messages in thread
From: Aurelien Jarno @ 2008-05-08 22:44 UTC (permalink / raw)
To: qemu-devel
Now that we have 3 TCG only targets (arm, cris, sparc) and 1 being
actively converted (mips), I think it does not make sense anymore to
build those targets with gcc-3.4.
For example on hppa, gcc-3.4 is buggy and unable to compile
target-sparc/softmmu.c. OTOH, I haven't found any noticeable speed
improvement comparing gcc-3.4 and gcc-4.3.
The patch below is maybe a bit hackish, but enables the use of the
default compiler for TCG only targets. I am not sure it is worth doing
a more complex patch given than all targets are supposed to be converted
to TCG sooner or later.
diff --git a/Makefile.target b/Makefile.target
index bb1f3e5..95e4152 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -1,5 +1,9 @@
include config.mak
+ifdef CONFIG_NO_DYNGEN_OP
+CC=$(HOST_CC)
+endif
+
TARGET_BASE_ARCH:=$(TARGET_ARCH)
ifeq ($(TARGET_ARCH), x86_64)
TARGET_BASE_ARCH:=i386
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [RFC][PATCH] Use HOST_CC instead of CC on TCG only targets
2008-05-08 22:44 [Qemu-devel] [RFC][PATCH] Use HOST_CC instead of CC on TCG only targets Aurelien Jarno
@ 2008-05-08 22:56 ` Paul Brook
0 siblings, 0 replies; 2+ messages in thread
From: Paul Brook @ 2008-05-08 22:56 UTC (permalink / raw)
To: qemu-devel; +Cc: Aurelien Jarno
On Thursday 08 May 2008, Aurelien Jarno wrote:
> Now that we have 3 TCG only targets (arm, cris, sparc) and 1 being
> actively converted (mips), I think it does not make sense anymore to
> build those targets with gcc-3.4.
FTR I'm (slowly) working on converting m68k.
> +ifdef CONFIG_NO_DYNGEN_OP
> +CC=$(HOST_CC)
> +endif
This breaks cross builds. $(HOST_CC) is the compiler for the build system
(yes, it's mis-named).
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-08 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-08 22:44 [Qemu-devel] [RFC][PATCH] Use HOST_CC instead of CC on TCG only targets Aurelien Jarno
2008-05-08 22:56 ` Paul Brook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).