From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JuoSk-00029p-4e
	for qemu-devel@nongnu.org; Sat, 10 May 2008 08:46:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JuoSi-000297-H5
	for qemu-devel@nongnu.org; Sat, 10 May 2008 08:46:05 -0400
Received: from [199.232.76.173] (port=36851 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JuoSi-000292-DD
	for qemu-devel@nongnu.org; Sat, 10 May 2008 08:46:04 -0400
Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:55724)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1JuoSh-0005Gg-Qa
	for qemu-devel@nongnu.org; Sat, 10 May 2008 08:46:04 -0400
Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout02-winn.ispmail.ntl.com with ESMTP id
	<20080510124941.GSQJ58.mtaout02-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Sat, 10 May 2008 13:49:41 +0100
Received: from miranda.arrow ([213.107.26.151])
	by aamtaout01-winn.ispmail.ntl.com with ESMTP id
	<20080510125040.OWFR219.aamtaout01-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Sat, 10 May 2008 13:50:40 +0100
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1JuoSY-0004zx-B2
	for qemu-devel@nongnu.org; Sat, 10 May 2008 13:45:54 +0100
Date: Sat, 10 May 2008 13:45:54 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [4406] fixed global variable handling with qemu
	load/ stores - initial global prologue/epilogue implementation
Message-ID: <20080510124554.GA19165@miranda.arrow>
References: <E1JumgQ-0007D2-3W@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1JumgQ-0007D2-3W@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, May 10, 2008 at 10:52:06AM +0000, Fabrice Bellard wrote:

> -#ifdef HOST_HPPA
> -    func_addr = (tcg_target_long)__canonicalize_funcptr_for_compare((void *)func_addr);
> -#endif

This was needed on HPPA (and possibly other archs), because a function
pointer can hold either the function's address, or that of a function
description (plabel), but we need the address of the function itself.

How would you prefer this to be handled?  Would a 'tcg_const_funcptr'
macro added to tcg.h and used in tcg_gen_helper_*_*() be okay?
-- 
Stuart Brady