From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4406] fixed global variable handling with qemu load/ stores - initial global prologue/epilogue implementation
Date: Sat, 10 May 2008 14:10:03 +0100 [thread overview]
Message-ID: <20080510131003.GA19279@miranda.arrow> (raw)
In-Reply-To: <20080510124554.GA19165@miranda.arrow>
On Sat, May 10, 2008 at 01:45:54PM +0100, Stuart Brady wrote:
> On Sat, May 10, 2008 at 10:52:06AM +0000, Fabrice Bellard wrote:
>
> > -#ifdef HOST_HPPA
> > - func_addr = (tcg_target_long)__canonicalize_funcptr_for_compare((void *)func_addr);
> > -#endif
>
> How would you prefer this to be handled?
Ouch -- I've just noticed that the right place to handle this was
tcg_out_call()... which in fact already does it!
I obviously meant to remove the __canonicalize_funcptr_for_compare from
tcg.c before I even submitted the code. Thanks for fixing it.
Another change I made was adding the 'func_addr' variable, and using it
in place of ts->val. I can submit a patch to revert that change if you
would like.
Cheers,
--
Stuart Brady
next prev parent reply other threads:[~2008-05-10 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 10:52 [Qemu-devel] [4406] fixed global variable handling with qemu load/ stores - initial global prologue/epilogue implementation Fabrice Bellard
2008-05-10 12:45 ` Stuart Brady
2008-05-10 13:10 ` Stuart Brady [this message]
2008-05-10 13:29 ` Fabrice Bellard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080510131003.GA19279@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).