From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Juoq0-0000gl-3u for qemu-devel@nongnu.org; Sat, 10 May 2008 09:10:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Juopz-0000gT-E6 for qemu-devel@nongnu.org; Sat, 10 May 2008 09:10:07 -0400 Received: from [199.232.76.173] (port=37281 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Juopz-0000gO-A7 for qemu-devel@nongnu.org; Sat, 10 May 2008 09:10:07 -0400 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:7422) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Juopy-0000iq-Iv for qemu-devel@nongnu.org; Sat, 10 May 2008 09:10:06 -0400 Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com with ESMTP id <20080510131338.EEV14647.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Sat, 10 May 2008 14:13:38 +0100 Received: from miranda.arrow ([213.107.26.151]) by aamtaout01-winn.ispmail.ntl.com with ESMTP id <20080510131449.PCRR219.aamtaout01-winn.ispmail.ntl.com@miranda.arrow> for ; Sat, 10 May 2008 14:14:49 +0100 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1Juopv-00051N-65 for qemu-devel@nongnu.org; Sat, 10 May 2008 14:10:03 +0100 Date: Sat, 10 May 2008 14:10:03 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] [4406] fixed global variable handling with qemu load/ stores - initial global prologue/epilogue implementation Message-ID: <20080510131003.GA19279@miranda.arrow> References: <20080510124554.GA19165@miranda.arrow> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080510124554.GA19165@miranda.arrow> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sat, May 10, 2008 at 01:45:54PM +0100, Stuart Brady wrote: > On Sat, May 10, 2008 at 10:52:06AM +0000, Fabrice Bellard wrote: > > > -#ifdef HOST_HPPA > > - func_addr = (tcg_target_long)__canonicalize_funcptr_for_compare((void *)func_addr); > > -#endif > > How would you prefer this to be handled? Ouch -- I've just noticed that the right place to handle this was tcg_out_call()... which in fact already does it! I obviously meant to remove the __canonicalize_funcptr_for_compare from tcg.c before I even submitted the code. Thanks for fixing it. Another change I made was adding the 'func_addr' variable, and using it in place of ts->val. I can submit a patch to revert that change if you would like. Cheers, -- Stuart Brady