From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JwdPR-00024S-0P for qemu-devel@nongnu.org; Thu, 15 May 2008 09:22:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JwdPP-00023i-E0 for qemu-devel@nongnu.org; Thu, 15 May 2008 09:22:12 -0400 Received: from [199.232.76.173] (port=49115 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JwdPP-00023e-8W for qemu-devel@nongnu.org; Thu, 15 May 2008 09:22:11 -0400 Received: from mx1.redhat.com ([66.187.233.31]:60622) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JwdPO-0006px-Uk for qemu-devel@nongnu.org; Thu, 15 May 2008 09:22:11 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m4FDMAHO004179 for ; Thu, 15 May 2008 09:22:10 -0400 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m4FDM8gM003491 for ; Thu, 15 May 2008 09:22:09 -0400 Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id m4FDM8a9006710 for qemu-devel@nongnu.org; Thu, 15 May 2008 14:22:08 +0100 Date: Thu, 15 May 2008 14:22:08 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] Add support for a configuration file Message-ID: <20080515132208.GB5983@redhat.com> References: <1210713545-11916-1-git-send-email-aliguori@us.ibm.com> <20080515220340.10e3fa92.mle+tools@mega-nerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, May 15, 2008 at 02:36:43PM +0200, andrzej zaborowski wrote: > On 15/05/2008, Erik de Castro Lopo wrote: > > One thing I'd like to see is the ability to include one config file > > inside another. > > That's a good idea, I suggested preprocessing with a cpp (-like) tool > with this in mind. This lets you kindof "make your own" syntax for > the config file, redefine instead of search&replace, and allows a lib > like libvirt to have its standard "base" config / "template" config > that would be included by the generated files and used. We don't really have a 'base' template for QEMU - we only specify the args that are explicitly required based on the user's libvirt XML config. Plus couple of extra ones to turn off default settings (eg -serial none) if the user didn't ask for a serial device. So I'd probably not need includes for the QEMU config. Definitely useful for people not using libvirt though Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|