From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JyoyH-0000nI-5G
	for qemu-devel@nongnu.org; Wed, 21 May 2008 10:07:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JyoyF-0000l3-IB
	for qemu-devel@nongnu.org; Wed, 21 May 2008 10:07:12 -0400
Received: from [199.232.76.173] (port=59265 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JyoyF-0000ku-Cc
	for qemu-devel@nongnu.org; Wed, 21 May 2008 10:07:11 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:54499)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JyoyF-0000bn-7Q
	for qemu-devel@nongnu.org; Wed, 21 May 2008 10:07:11 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [4476] musicpal: Improve button handling (Jan
	Kiszka).
Date: Wed, 21 May 2008 15:07:05 +0100
References: <E1JxQys-000218-7v@cvs.savannah.gnu.org>
	<g0uvq6$521$1@ger.gmane.org>
	<18484.8433.525986.172414@mariner.uk.xensource.com>
In-Reply-To: <18484.8433.525986.172414@mariner.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="ansi_x3.4-1968"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200805211507.05887.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>

> > Target arm-softmmu still does not compile on Windows. The fix is trivial,
> > please apply it (or my previous patch, if you wish).
> >
> > +#ifdef _WIN32
> > +    Sleep(1000);
> > +#else
> >      sleep(1);
> > +#endif
>
> Surely this should be in osdep.h as a conditional definition of sleep.

The real bug is that we're using sleep() in the first place :-)

Paul