From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyqHf-0002qX-4S for qemu-devel@nongnu.org; Wed, 21 May 2008 11:31:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyqHd-0002nt-Ap for qemu-devel@nongnu.org; Wed, 21 May 2008 11:31:18 -0400 Received: from [199.232.76.173] (port=52046 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyqHd-0002nU-0y for qemu-devel@nongnu.org; Wed, 21 May 2008 11:31:17 -0400 Received: from mail2.shareable.org ([80.68.89.115]:51540) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JyqHc-0002xI-M0 for qemu-devel@nongnu.org; Wed, 21 May 2008 11:31:16 -0400 Received: from jamie by mail2.shareable.org with local (Exim 4.63) (envelope-from ) id 1JyqHb-0005Ph-ID for qemu-devel@nongnu.org; Wed, 21 May 2008 16:31:15 +0100 Date: Wed, 21 May 2008 16:31:15 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] Re: [PATCH][v2] Align file accesses with cache=off (O_DIRECT) Message-ID: <20080521153115.GA20527@shareable.org> References: <1211283126.4314.70.camel@frecb07144> <48332AB9.3010707@codemonkey.ws> <20080520223602.GE27853@shareable.org> <48337444.2070203@codemonkey.ws> <20080521011915.GC595@shareable.org> <48338522.7030306@codemonkey.ws> <0BD236FF-3907-4A00-B32A-158C7E538452@web.de> <48342C66.9080407@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48342C66.9080407@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > >If you change part of the data but leave the checksum as-is, you'd > >hopefully get a checksum mismatch... ;) > > That's the point though, you're not changing part of the data. You're > rewriting the same data. Usually you're changing some bytes in a block but leaving others the same. Why else would you write at all? But even if you do write the same bits _exactly_, the bits written will not overlay the original data bits precisely enough to make aborting in the middle seamless. -- Jamie