From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JzAig-00038d-5d
	for qemu-devel@nongnu.org; Thu, 22 May 2008 09:20:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JzAic-00037S-PZ
	for qemu-devel@nongnu.org; Thu, 22 May 2008 09:20:33 -0400
Received: from [199.232.76.173] (port=43251 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JzAic-00037M-Ig
	for qemu-devel@nongnu.org; Thu, 22 May 2008 09:20:30 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:50082)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JzAic-0002UD-4S
	for qemu-devel@nongnu.org; Thu, 22 May 2008 09:20:30 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2)
Date: Thu, 22 May 2008 14:20:17 +0100
References: <1211404888-29146-1-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1211404888-29146-1-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200805221420.19520.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>

> +# Check if any targets require dyngen
> +for target in $target_list; do

You've just duplicated this logic. Please don't.

Paul